Permalink
Browse files

Escape potential spaces in file URLs

If the Git bundle is checked out to Application Support then TM_BUNDLE_SUPPORT will contain a space.

Not escaping spaces in file URLs seems to have worked in the past (with WebKit) but escaping them is the right thing to do, and it does not work in macOS 10.12.
  • Loading branch information...
1 parent 9cf5c12 commit ad28c88dfb18e1a3c180b3a14bbc3069cbb509a0 @sorbits sorbits committed Oct 8, 2017
Showing with 1 addition and 1 deletion.
  1. +1 −1 Support/tmvc/lib/html_helpers.rb
@@ -11,7 +11,7 @@ def path_for(default_path, path)
protected
def resource_url(filename)
- "file://#{ENV['TM_BUNDLE_SUPPORT']}/resource/#{filename}"
+ "file://" + e_url("#{ENV['TM_BUNDLE_SUPPORT']}/resource/#{filename}")
end
def select_box(name, select_options = [], options = {})

0 comments on commit ad28c88

Please sign in to comment.