some Octave keywords are missing #2

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@schoeps
Contributor

schoeps commented Mar 2, 2013

Octave specific keywords: end_try_catch, endfor, endfunction, endif, endwhile

@infininight

This comment has been minimized.

Show comment
Hide comment
@infininight

infininight Mar 2, 2013

Member

Did a quick google search to verify this change and found a list of reserved keywords:

http://www.gnu.org/software/octave/doc/interpreter/Keywords.html

Many of which are not handled in the grammar. Also we should add these to the folding/indent settings.

Member

infininight commented Mar 2, 2013

Did a quick google search to verify this change and found a list of reserved keywords:

http://www.gnu.org/software/octave/doc/interpreter/Keywords.html

Many of which are not handled in the grammar. Also we should add these to the folding/indent settings.

@schoeps

This comment has been minimized.

Show comment
Hide comment
@schoeps

schoeps Mar 2, 2013

Contributor

You are right. I just corrected what was bothering me. Will you take care of those additional corrections? If not I can do it, but it will take some time. I am not an expert in Textmate's syntax definitions...

Contributor

schoeps commented Mar 2, 2013

You are right. I just corrected what was bothering me. Will you take care of those additional corrections? If not I can do it, but it will take some time. I am not an expert in Textmate's syntax definitions...

@schoeps

This comment has been minimized.

Show comment
Hide comment
@schoeps

schoeps Aug 2, 2013

Contributor

I have added some more features to my fork. It includes now the "parfor" keyword as proposed by cerveza1988 and it allows to execute a code selection in Terminal, similar to the code proposed by https://github.com/DGrady/matlab.tmbundle. My script works for both Octave and Matlab.

Please let me know, what to do regarding the old folding/indent issue such that the changes can go upstream.

Contributor

schoeps commented Aug 2, 2013

I have added some more features to my fork. It includes now the "parfor" keyword as proposed by cerveza1988 and it allows to execute a code selection in Terminal, similar to the code proposed by https://github.com/DGrady/matlab.tmbundle. My script works for both Octave and Matlab.

Please let me know, what to do regarding the old folding/indent issue such that the changes can go upstream.

@infininight

This comment has been minimized.

Show comment
Hide comment
@infininight

infininight Oct 12, 2013

Member

Delayed merging this so I could work on merging all of the various work that's been done into one. Seems there are a few items missing from your execute command though?

Theres a lot of oddness in the bundle still but I've merged in a lot of new items. Honestly thinking about splitting these into an Octave and a Matlab bundle, even though they are technically compatible it seems there are a lot of exceptions to the compatibility that make the bundle more complicated. Haven't decided yet though, open to comments there.

Member

infininight commented Oct 12, 2013

Delayed merging this so I could work on merging all of the various work that's been done into one. Seems there are a few items missing from your execute command though?

Theres a lot of oddness in the bundle still but I've merged in a lot of new items. Honestly thinking about splitting these into an Octave and a Matlab bundle, even though they are technically compatible it seems there are a lot of exceptions to the compatibility that make the bundle more complicated. Haven't decided yet though, open to comments there.

@schoeps

This comment has been minimized.

Show comment
Hide comment
@schoeps

schoeps Oct 14, 2013

Contributor

Yes, possibly. Do you know what is actually missing? As far as I remember I uncluttered the shell commands a bit but it should be more or less easy to incorporate.

I would think that splitting the bundles is more effort than keeping them in one. In the end, the syntax is the same with only a few different keywords. You would need to duplicate a lot and keeping future changes in sync could become a pain (because people will send patches only for their bundle).

Contributor

schoeps commented Oct 14, 2013

Yes, possibly. Do you know what is actually missing? As far as I remember I uncluttered the shell commands a bit but it should be more or less easy to incorporate.

I would think that splitting the bundles is more effort than keeping them in one. In the end, the syntax is the same with only a few different keywords. You would need to duplicate a lot and keeping future changes in sync could become a pain (because people will send patches only for their bundle).

@infininight

This comment has been minimized.

Show comment
Hide comment
@infininight

infininight Oct 14, 2013

Member

If you look at d22da94 it should be pretty obvious that some items are missing. There is no Spawn command and the Execute command references the wrong script name without the required arguments.

Member

infininight commented Oct 14, 2013

If you look at d22da94 it should be pretty obvious that some items are missing. There is no Spawn command and the Execute command references the wrong script name without the required arguments.

@infininight

This comment has been minimized.

Show comment
Hide comment
@infininight

infininight Oct 15, 2013

Member

Pulled in everything but the ⌘R changes.

Member

infininight commented Oct 15, 2013

Pulled in everything but the ⌘R changes.

@schoeps

This comment has been minimized.

Show comment
Hide comment
@schoeps

schoeps Oct 16, 2013

Contributor

Perfect. I will clone your version and try to reimplement the Octave compatibility stuff. I guess this makes most sense.

Contributor

schoeps commented Oct 16, 2013

Perfect. I will clone your version and try to reimplement the Octave compatibility stuff. I guess this makes most sense.

@infininight

This comment has been minimized.

Show comment
Hide comment
@infininight

infininight Dec 8, 2015

Member

Closing this since there has been no activity, open a new pull request if there are further items to consider.

Member

infininight commented Dec 8, 2015

Closing this since there has been no activity, open a new pull request if there are further items to consider.

@infininight infininight closed this Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment