Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
improved citations command to support dropdown list #5
Conversation
Sep 12, 2011
and others
added some commits
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
comments help explain how this fairly complex regex works |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
replied
Jul 13, 2012
This doesn't allow for headers where there is no space after == |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tbates
Jul 13, 2012
Owner
I haven't changed much here except make the comments more self-explanatory
Doesn't the unchanged line 15 allow for no trailing \s with the "*" match, no?
Or are you asking about line 17? That seems fine to me. And the headers appear fine in the symbol list no matter what white space exists in them
I haven't changed much here except make the comments more self-explanatory Doesn't the unchanged line 15 allow for no trailing \s with the "*" match, no? Or are you asking about line 17? That seems fine to me. And the headers appear fine in the symbol list no matter what white space exists in them |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
replied
Jul 13, 2012
Sorry this comment was for entirely a different commit. :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
letting the markup head match the new font size system |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
like it says on the tin: folding now works in mediawiki |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
replied
Jul 13, 2012
This doesn't allow for headers where there is no space after == |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tbates
May 20, 2012
Owner
expanding this as needed to match the new heading styles (needs a name for each level, rather than just styling everything as "heading"
expanding this as needed to match the new heading styles (needs a name for each level, rather than just styling everything as "heading" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tbates
May 20, 2012
Owner
just letting the system detect files with line 1 being a commented out mediawiki
might be more flexible to look for just this word on line 1
just letting the system detect files with line 1 being a commented out mediawiki might be more flexible to look for just this word on line 1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
Jul 13, 2012
With the | in the place that it is this matches near empty lines, not seeing the point of the first half of it.
infininight
replied
Jul 13, 2012
With the | in the place that it is this matches near empty lines, not seeing the point of the first half of it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tbates
Jul 13, 2012
Owner
the fist part was to match a line beginning with "=" I've commited a patch make it look for = at the start and end of the non-white space on line 1
the fist part was to match a line beginning with "=" I've commited a patch make it look for = at the start and end of the non-white space on line 1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
Jul 13, 2012
I think that rule is going to be too loose, simply having a line with = isn't enough I think.
infininight
replied
Jul 13, 2012
I think that rule is going to be too loose, simply having a line with = isn't enough I think. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
fixed, i think |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tbates
May 20, 2012
Owner
this fixed a bug in the file, such that some commands made the wrong level of heading
this fixed a bug in the file, such that some commands made the wrong level of heading |
tbates
and others
added some commits
May 21, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
commented on 4993ea8
Jul 13, 2012
This snippet is missing a scope. |
infininight
and others
added some commits
Jul 13, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
infininight
Jan 12, 2013
Owner
Went through and cleaned these up merging and pruning where neccesary and have pulled everything with the exception of:
- 35d178c / 15c32d4: I still feel that the line match is too broad as other languages may use a similar format for headers, etc.
- 52b7f97: There are currently two of these snippets present, I only kept one of them.
- c3f6f1f: I left this commit out because of an unclean commit intitially. I did investigated further and found that while it fixed one error it caused another so I left it out for now.
Get with me on IRC if you have any questions, also ask me to help you reset your fork when applicable.
Went through and cleaned these up merging and pruning where neccesary and have pulled everything with the exception of:
Get with me on IRC if you have any questions, also ask me to help you reset your fork when applicable. |
tbates commentedOct 9, 2012
No description provided.