Added traits support #27

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@unRob
unRob commented Oct 16, 2012

Also added the fastcgi_finish_request() function

unRob added some commits Oct 16, 2012
@unRob unRob Added trait support
Also added the fastcgi_finish_request() function
d003d22
@unRob unRob Added correct indentation for new array declaration
As of PHP 5.4, arrays can be declared as `[ ]`, so following PEAR's
style guide, the contents of such arrays could be indented.
59b1a34
@unRob
unRob commented Oct 29, 2012

@infininight Hey Michael, would you mind taking a look at this? Thanks!

@infininight
Member

I've added the indention fix, the first one puts items in files we regenerate periodically though, so they would get blown away when that gets updated.

@unRob
unRob commented Nov 26, 2012

Thanks Michael! Where should I look into to have traits and fastcgi_finish_request() updated into the periodic regeneration?

@unRob
unRob commented Nov 26, 2012

Cool, will look into it and commit again.

@infininight
Member

Open a new pull request or reopen this one when that is done.

@koenpunt

@unRob Any progress yet? :)

@unRob
unRob commented Jan 30, 2013

None so far, I have to look into https://github.com/textmate/php.tmbundle/tree/master/Support/generate, but haven't had the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment