Browse files

Disable Xcode data source by default

It can be enabled by setting the ‘enableXcodeDataSource’ defaults key to YES.

The reason it has been disabled is that there is a file browser (crash) issue, and the 3 users who have provided steps to reproduce all mention clicking an Xcode project (though myself and Michael Sheets have been unable to reproduce, following those steps, and I do not think the bug is with the Xcode data source, but it does seem to be a catalyst).
1 parent 8785f0e commit 2c524907d6a36cd3c0f14e52a9b973ed2ac1822c @sorbits sorbits committed Dec 10, 2016
Showing with 1 addition and 1 deletion.
  1. +1 −1 Frameworks/OakFileBrowser/src/io/
@@ -124,7 +124,7 @@ - (void)loadChildren:(FSDirectoryDataSource*)dataSource completionHandler:(void(
treat_as_directory = !(flags & (path::flag::package|path::flag::hidden_volume));
target = to_s([[NSURL fileURLWithPath:[NSString stringWithCxxString:path] isDirectory:path::flag::directory|path::flag::package] absoluteString]);
- if(path::extension(path) == ".xcodeproj")
+ if(path::extension(path) == ".xcodeproj" && [[NSUserDefaults standardUserDefaults] boolForKey:@"enableXcodeDataSource"])
target = "xcodeproj://localhost" + encode::url_part(path, "/") + "/";
else if(entry->d_type == DT_REG)

0 comments on commit 2c52490

Please sign in to comment.