Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support text links with VoiceOver #1184
Now links in text (e.g. links to RFCs after installing the Hyperlink Helper
Also I noticed when testing the accessibilityHitPoint with Accessibility Inspector
The y values (
As always, I release the patch to the public domain. Thanks for your review.
Now links in text (e.g. links to RFCs after installing the Hyperlink Helper bundle) are announced as such with VoiceOver and it is possible to search for them with VO-Cmd-L. TODO: * launching links with VO-Space is not supported yet, but Enter (Fn-Return) does the same thing and is even more reliable. * link URL is not supported, so it is not possible to learn the URL with VO-Shift-U.
Thanks, merged as 5dcca09.
Changed one use of the
Removed spaces after
Let asterisk bind to type instead of value (e.g.
Changed most opening braces to be on their own line — I left the chained if-else-if… code since it would double the number of lines — normally I would do it without braces at all.
Possibly a few other minor tweaks, but everything should be limited to syntax.
I reviewed the changes you made, I will try to remember those things the next time :-)
I am wondering if you noticed my question about the layout returning rect of width -1. If you have no idea or hypothesis (or time), it's fine, I will look into it myself, but if you have any idea that could maybe point me into the right direction, I would of course appreciate it.
Sorry, I forgot about the question.
The missing X metrics are due to lazy layout. It’s easy to estimate
It’s possible to call layout_t::update_metrics to force a layout, but
I don’t know if this poses an actual problem; once the link has
On 16 Nov 2013, at 18:23, Boris Dušek wrote: