/ textmate Public
Support text links with VoiceOver #1184
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Now links in text (e.g. links to RFCs after installing the Hyperlink Helper
bundle) are announced as such with VoiceOver and it is possible to search for
them with VO-Cmd-L.
does the same thing and is even more reliable.
Also I noticed when testing the accessibilityHitPoint with Accessibility Inspector
that the frame reported by
linksconstruction method (line 1476) is always
wrong in the x-axis -
frame.size.width == -1
frame.origin.xsome small value.
The y values (
frame.origin.y) appear to be correct.
What is strange that then the code for AXBoundsForRange (line 1338) also calls
again for the same range and reports the correct frame. Any thoughts on what this
might be caused by before I investigate more? Could I be catching the
inconsistent or semi-updated state?
As always, I release the patch to the public domain. Thanks for your review.