/ textmate Public
Improve accessibility of Find dialog (+small stuff) #1221
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
These commits improve accessibility of Find dialog by setting accessibility
labels for various UI elements and announcing result directly in one case.
While I was at it, I improved a little bit in the same spirit old code for
accessibility in status bar, and added one of my email address hashes.
I am not sure with
idin my commits - I used
it is more type strict, but if the TextMate's convention is to use
cases, please feel free to change it that way (or tell me to change it).
Also there is one issue - the Find/Replace history menu is in a new window
to which VoiceOver does not switch automatically (only announces a "new window"
and provides no feedback when navigating just with arrows up/down (as opposed
to VO-up/down), but fixing that is beyond the scope of work I want to do right
now (and maybe beyond what I am capable of right now :-).
I release these patches into public domain.