Fixes and improvements for the Zoom accessibility feature #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bol_as_eol was meant for non-empty ranges, but the only place where empty ranges were attempted with bol_as_eol was for Zoom tracking, and it seems like I did not re-test Zoom after making the bol_as_eol commit. Fixes textmate/bugs#4
When setSelectionString is called during editing of text (like inserting or deleting a character), it catches layout in a semi-consistent state where horizontal position of individual characters cannot be determined. Therefore during such events, we cannot pass the correct screen position to the call to UAZoomChangeFocus. So let's do the UAZoomChangeFocus call after this iteration of run loop. This ensures everything in layout that had to update has updated when calling UAZoomChangeFocus, thus enabling us to provide correct horizontal screen position.
This makes Zoom support avoid doing all 2 conversions between UTF-8 to UTF-16, and replaces call to rect_for_range with call to rect_at_index, which is more efficient. Note that this is a typical micro-optimization not resulting from any actual performance measurement, but just from a desire to have a lean code not doing redundant work.
Use `performSelector:withObject:afterDelay:` instead of dispatch_async for `UAZoomChangeFocus` (Zoom focus change notifications).
Remove extra newline after a method
|
I added 2 new commits, one for the |
|
Thanks, merged as 754f1a1...7e01bab. I added a (dummy) argument to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for details.
I release these patches into the public domain.