New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accessibility in text view - VoiceOver and Zoom #621

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dusek
Contributor

dusek commented Dec 9, 2012

These commits enable visually impaired and blind users on OS X to use VoiceOver and Zoom in the text component of TextMate. Both commits contain a bit more detailed description of the changes.

I have a few points which might use some discussion:

  • is [OakTextView setSelectionString] the right place to track selection changes? It feels this is not the place where the selection model is defined (it is I guess in document or editor objects), but just reflected. I had no problem to find the right place for tracking of text model changes (buffer callbacks), but no luck finding right place to track selection model changes. However, tracking selection in setSelectionString seems to work absolutely fine.
  • the nsRangeForRange and rangeForNSRange methods could be optimized for O(log n) in similar way as basic_tree_t is (as noted in the code comment). These methods could also be used in the relevant NSTextInput methods instead of the manual code currently present there - if there is interest, I can make a follow-up commit to use them for that code as well.

Both patches (commits) are released as public domain by my employer, BRAILCOM,o.p.s.

dusek added some commits Oct 4, 2012

VoiceOver/accessibility support for text view
This commit adds support for most common accessibility
methods/attributes to the OakTextView component. In user's language,
VoiceOver users (i.e. blind and visually impaired users) can now use
TextMate to read and write text.

A few less used accessibility attributes remain to be supported -
especially AttributedStringForRange and StyleRangeForIndex which should
allow blind users to e.g. see and seek for spelling errors in text.
Add support for Zoom
Zoom is an OS X accessibility feature that lets sighted visually
impaired users magnify screen content. This commit notifies Zoom of
changes of TextMate's cursor position on screen so that Zoom can
automatically follow the cursor when the user moves it.

@ghost ghost assigned sorbits Dec 11, 2012

@sorbits

This comment has been minimized.

Member

sorbits commented Dec 14, 2012

Awesome work, thanks!

Pulled as commit 224ee5f and commit 5369b7c. I made a few syntactic changes and also prepended a commit that factors out the NSRange/ng::range conversion methods (which are now also used by the NSTextInput support methods, as you suggested — I prepended it to make your commit smaller, thus less to review).

As for your considerations: setSelectionString: would be the proper place. While the selection model is at a lower level, for accessibility we don’t want to “go down there” as it could be changed without any visual rendering (e.g. macro, script (in the future), etc.).

Performance of converting between UTF-8 and UTF-16 is indeed bothersome, but I think as these conversions are only done “on user requests” there is probably no actual performance issues (user input is limited to 30-50 per second, and even with humongous documents, doing the UTF-8/16 calculations should be faster than 1/30th of a second). So at least for now, this should be fine.

@sorbits sorbits closed this Dec 14, 2012

@dusek

This comment has been minimized.

Contributor

dusek commented Dec 15, 2012

Thanks for reviewing and pulling these in. You are right that the UTF-8/UTF-16 conversions are not an issue in practice - I tried it with VoiceOver and there were no performance issues on a bigger document - which happened to be OakTextView.mm itself :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment