Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Support accessibility in text view - VoiceOver and Zoom #621
These commits enable visually impaired and blind users on OS X to use VoiceOver and Zoom in the text component of TextMate. Both commits contain a bit more detailed description of the changes.
I have a few points which might use some discussion:
Both patches (commits) are released as public domain by my employer, BRAILCOM,o.p.s.
This commit adds support for most common accessibility methods/attributes to the OakTextView component. In user's language, VoiceOver users (i.e. blind and visually impaired users) can now use TextMate to read and write text. A few less used accessibility attributes remain to be supported - especially AttributedStringForRange and StyleRangeForIndex which should allow blind users to e.g. see and seek for spelling errors in text.
Awesome work, thanks!
Pulled as commit 224ee5f and commit 5369b7c. I made a few syntactic changes and also prepended a commit that factors out the
As for your considerations:
Performance of converting between UTF-8 and UTF-16 is indeed bothersome, but I think as these conversions are only done “on user requests” there is probably no actual performance issues (user input is limited to 30-50 per second, and even with humongous documents, doing the UTF-8/16 calculations should be faster than 1/30th of a second). So at least for now, this should be fine.
Thanks for reviewing and pulling these in. You are right that the UTF-8/UTF-16 conversions are not an issue in practice - I tried it with VoiceOver and there were no performance issues on a bigger document - which happened to be OakTextView.mm itself :-)