Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OakTabBarView accessible #669

Closed
wants to merge 1 commit into from

Conversation

@dusek
Copy link
Contributor

@dusek dusek commented Jan 13, 2013

In short: VoiceOver users can browse the tabs, switch between them with the default action (press), invoke context menus on them, and learn if a tab indicates whether a file is modified or not.

Released in public domain by my employer, BRAILCOM,o.p.s.

@sorbits
Copy link
Member

@sorbits sorbits commented Jan 17, 2013

Great work (again), pulled as 1bcdf4a (with just some minor formatting changes).

How do you bring up the context menu for the tabs (with VO enabled)?

@sorbits sorbits closed this Jan 17, 2013
@dusek
Copy link
Contributor Author

@dusek dusek commented Jan 17, 2013

Thanks again for reviewing and pulling.

W.r.t. the context menu - I am using the showMenu:inRect:withSelectedIndex:font:popup method (I think it's a method of OakControl, not OakTabBarView itself) after I set the tab's tag on the OakTabBarView. You can search for NSAccessibilityShowMenuAction (or simply for showmenu) in the diff and see the 3 lines of code that follow the last occurence of that string in the diff (lines 467-469).

@sorbits
Copy link
Member

@sorbits sorbits commented Jan 17, 2013

Sorry, what I meant was, what key equivalent causes VO to bring up this menu (send NSAccessibilityShowMenuAction)?

@dusek
Copy link
Contributor Author

@dusek dusek commented Jan 17, 2013

The key equivalent is VO-Shift-M ("VO" stands for Ctrl+Option, it's a standard prefix for all VoiceOver shortcuts). It's a "variation" on VO-M, which goes to the main menu.

@dusek dusek deleted the accessibility-tabbar.2 branch Mar 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants