Improve VoiceOver labels for images/pop-ups etc. #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoiceOver reads an AXValue for a pop-up button - that is the selected item. But button's title does not set an AXValue, as it probably is not a menu item. So change the code set to the title by setting a single menu item with that title. This fixes accessibility of the pop-up when accessing its value before it is first popped up. It makes the code consistent with setGrammarName: which works fine (that's how I discovered how to fix it).
This fixes semantics of the button and thus also its
accessibility. The macro recording button represents state - more
specifically a boolean state, so it has to be a NSToggleButton (or
its specialization). Then the button is presented to the VoiceOver
user as an AXCheckbox - that is a checkbox with on and off value -
which is exactly what the button's function is. Examples of this in
system apps is e.g. the "Play" button in QuickTime Player, which is
also an AXCheckbox ("Pause" is then simply an unchecked "Play"
checkbox).
|
Pulled as 7892eac...944e1e3. Appreciate the commit messages! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches improve accessibility of UI elements in the main window by
setting proper descriptions for image buttons / pop-ups and proper roles.
Non-obvious stuff is discussed in commit messages of individual commits.
These patches are released to public domain by my employer, BRAILCOM,o.p.s.