Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Improve accessibility of file browser items #929
More info in the commit message as usual.
I guess the main point of discussion here is where the appropriate code belongs - whether or not it is right to set the
These patches are released to public domain by my employer, BRAILCOM,o.p.s.
Make available to accessibility the following information that file browser displays visual indication for: * file type (whether the file is a file, folder etc.) * SCM status (whether the file is modified etc.) * close button (whether the file is open) Also, while we are at it, make available to accessibility the tooltip, filename and URL.
Merged as 65ae6a2.
It’s been a while since I wrote the file browser code, but I think I moved away from represented object to make the cell more reusable, i.e. no tight coupling to a custom type used in the file browser framework (
As for the exposed accessibility attributes, I am thinking SCM status should probably be limited to a few select statuses, like modified, conflicted, added, and removed.