New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of file browser items #929

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dusek
Contributor

dusek commented Mar 30, 2013

More info in the commit message as usual.

I guess the main point of discussion here is where the appropriate code belongs - whether or not it is right to set the representedObject of OFBPathInfoCell to the relevant FSItem and use this info
rmation inside the OFBPathInfoCell accessibility support (this is the way I did it as I felt OFBPathInfoCell should know its accessibility since it could be used in more than one place, like File C
hooser, which, however, does not seem to reflect this accessibility support as it has its own logic to determine file attributes), or whether to set the accessibility attributes as override values in [FSOutlineViewDelegate willDisplayCell:...].

These patches are released to public domain by my employer, BRAILCOM,o.p.s.

Improve accessibility of file browser items
Make available to accessibility the following information that file
browser displays visual indication for:

* file type (whether the file is a file, folder etc.)
* SCM status (whether the file is modified etc.)
* close button (whether the file is open)

Also, while we are at it,  make available to accessibility the
tooltip, filename and URL.
@sorbits

This comment has been minimized.

Member

sorbits commented Apr 2, 2013

Merged as 65ae6a2.

It’s been a while since I wrote the file browser code, but I think I moved away from represented object to make the cell more reusable, i.e. no tight coupling to a custom type used in the file browser framework (FSItem). That said, the cell was never made truly public and just used as a provisional solution in the file chooser framework (which doesn’t have access to the FSItem type and only set attributes), pending some refactoring related to this. I can sort out the cell’s accessibility shortcomings when used in the file chooser framework, when I get around to refactoring this stuff.

As for the exposed accessibility attributes, I am thinking SCM status should probably be limited to a few select statuses, like modified, conflicted, added, and removed.

@sorbits sorbits closed this Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment