New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nan, inf, hex, oct, bin values #10

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ToruNiina
Contributor

ToruNiina commented Sep 26, 2018

Hi,

As you can see, the special float values that are introduced in TOML 0.5.0 are highlighted in red.
inf_nan
And hexadecimal, octal, and binary integers are also colored red.
toml_hex_oct_bin

This PR is for fixing these issues.
Please check it.

Thank you.

@infininight

This comment has been minimized.

Member

infininight commented Oct 10, 2018

No issues with 2eb71bd, pulled as 4fc3127. Added an additional commit to split these into separate rules as the regex was getting a bit unwieldy.

9a6e694 was much more complicated than it needed be. All we care about here is checking the following text that it appears to be a valid value. Ensuring perfection here isn't required as the #invalid rules will catch anything that ends up being bad. This entire rule is really not to ensure the validity of the values but to ensure two values don't exist without a comma separator. Simplified and pulled as 4fc3127.

Thanks for the PR. Note that these changes have been deployed for TextMate but deploys to GitHub highlighting happen periodically every few weeks so there will be a delay before the highlighting is correct there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment