Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subheading inconsistency in admin side #142

Closed
ghost opened this issue Oct 4, 2014 · 4 comments
Closed

Subheading inconsistency in admin side #142

ghost opened this issue Oct 4, 2014 · 4 comments

Comments

@ghost
Copy link

@ghost ghost commented Oct 4, 2014

From p...@designhive.com on February 25, 2012 15:03:00

What is the expected output? What do you see instead? The is currently inconsistency in the subheadings throughout the admin-side templates, some use H2 tag, some use H3 tag (which is also used for levers). Need to standardise (preferable to H2). What version of the product are you using? On what operating system? 4.4.1 Please provide any additional information below. Can be fixed by the following changes: https://github.com/philwareham/textpattern/commit/86ddca683fa0c4a8da2f29b9cd14c6fde6a83ca5 https://github.com/philwareham/textpattern/commit/d760240d8a76d5e2f103396b92eed1d4ba0f709c Also (minor issue), pophelp icon when used on h2 tag (such as Sections heading) is slightly larger than all other pophelp icons, this would fix it: https://github.com/philwareham/textpattern/commit/02efc4894c561b2f95498e83aca4d55e9c329d6f

Original issue: http://code.google.com/p/textpattern/issues/detail?id=138

@ghost ghost added the imported label Oct 4, 2014
@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From r.wetzlmayr on March 11, 2012 23:25:57

How would a change affect/break existing themes?

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From p...@designhive.com on March 12, 2012 03:01:52

There should be minimal issues with current themes. Since a few of the admin-side subheadings are already h2 tags (such as the Sections title) the appropriate styling should already exist in most themes. Worst case is that some subhead text is slightly wrong size, but nothing that could break the theme.

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From stefdawson on March 15, 2012 07:35:59

This issue was closed by revision r3677 .

Status: Fixed

@ghost ghost closed this Oct 4, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
and others
You can’t perform that action at this time.