What steps will reproduce the problem? 1. Edit an image caption in the Images tab, and include single and double quotes, like this:
"Textism", Dean Allen's website, is often 'Retooling'.
Use the caption in a template, like so, using single quotes to enclose the caption in a title attribute:
txp:imagestxp:thumbnail//txp:images
Visit a page that displays the image template. What is the expected output? What do you see instead? Here's the generated markup:
Textpattern wisely transforms double quote characters " into " entities to avoid breaking HTML attributes enclosed by double quotes, but single quote characters ' are not transformed into entities. Since enclosing attributes in single quotes is valid HTML5 and widely-used in HTML5 reference material, Textpattern should sanitize single quotes in caption content. Textile's smart quotes would be great, but even entity ' would work. What version of the product are you using? On what operating system? 4.4.1 on Unix
From j...@designop.us on April 10, 2012 07:55:07
What steps will reproduce the problem? 1. Edit an image caption in the Images tab, and include single and double quotes, like this:
txp:imagestxp:thumbnail//txp:images
Textpattern wisely transforms double quote characters
"
into"
entities to avoid breaking HTML attributes enclosed by double quotes, but single quote characters'
are not transformed into entities. Since enclosing attributes in single quotes is valid HTML5 and widely-used in HTML5 reference material, Textpattern should sanitize single quotes in caption content. Textile's smart quotes would be great, but even entity ' would work. What version of the product are you using? On what operating system? 4.4.1 on UnixOriginal issue: http://code.google.com/p/textpattern/issues/detail?id=163
The text was updated successfully, but these errors were encountered: