Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSingle prime apostrophe in image caption content triggers error when used in HTML attributes that are quoted with single quotes. #167
Comments
This comment has been minimized.
This comment has been minimized.
From r.wetzlmayr on June 20, 2012 05:40:52 This issue was closed by revision r3818 . Status: Fixed |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From j...@designop.us on April 10, 2012 07:55:07
What steps will reproduce the problem? 1. Edit an image caption in the Images tab, and include single and double quotes, like this:
txp:imagestxp:thumbnail//txp:images
Textpattern wisely transforms double quote characters
"
into"
entities to avoid breaking HTML attributes enclosed by double quotes, but single quote characters'
are not transformed into entities. Since enclosing attributes in single quotes is valid HTML5 and widely-used in HTML5 reference material, Textpattern should sanitize single quotes in caption content. Textile's smart quotes would be great, but even entity ' would work. What version of the product are you using? On what operating system? 4.4.1 on UnixOriginal issue: http://code.google.com/p/textpattern/issues/detail?id=163