Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single prime apostrophe in image caption content triggers error when used in HTML attributes that are quoted with single quotes. #167

Closed
ghost opened this issue Oct 4, 2014 · 1 comment

Comments

@ghost
Copy link

@ghost ghost commented Oct 4, 2014

From j...@designop.us on April 10, 2012 07:55:07

What steps will reproduce the problem? 1. Edit an image caption in the Images tab, and include single and double quotes, like this:

"Textism", Dean Allen's website, is often 'Retooling'.

  1. Use the caption in a template, like so, using single quotes to enclose the caption in a title attribute:

txp:imagestxp:thumbnail//txp:images

  1. Visit a page that displays the image template. What is the expected output? What do you see instead? Here's the generated markup:
    My alt text

Textpattern wisely transforms double quote characters " into " entities to avoid breaking HTML attributes enclosed by double quotes, but single quote characters ' are not transformed into entities. Since enclosing attributes in single quotes is valid HTML5 and widely-used in HTML5 reference material, Textpattern should sanitize single quotes in caption content. Textile's smart quotes would be great, but even entity ' would work. What version of the product are you using? On what operating system? 4.4.1 on Unix

Original issue: http://code.google.com/p/textpattern/issues/detail?id=163

@ghost ghost added the imported label Oct 4, 2014
@ghost

This comment has been minimized.

Copy link
Author

@ghost ghost commented Oct 4, 2014

From r.wetzlmayr on June 20, 2012 05:40:52

This issue was closed by revision r3818 .

Status: Fixed

@ghost ghost closed this Oct 4, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
0 participants
You can’t perform that action at this time.