Skip to content

Textpattern 4.8.8 release flight plan #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
24 of 25 tasks
petecooper opened this issue Jul 29, 2021 · 87 comments
Closed
24 of 25 tasks

Textpattern 4.8.8 release flight plan #1720

petecooper opened this issue Jul 29, 2021 · 87 comments

Comments

@petecooper
Copy link
Member

petecooper commented Jul 29, 2021

We are targeting Textpattern 4.8.8 for release in Q4 2021 to provide initial support for PHP 8.1, address some snags, and provide further refinements. The release flight plan includes at least one beta release before the production release.

Please update this post and subsequent replies with tasks etc as needed, assigning yourself or others where appropriate.

Timeline

  • beta release: 1 January 2022
  • GA release: 24 January 2022

Repo Issues

Production Release

Personnel

  • Release pilot: tbc
  • Release co-pilot: tbc

Preflight

  • preflight
    • latest translations (@philwareham)
    • latest pophelp (@philwareham)
    • draft .com blog post (release pilot, or assigned person)
    • write HISTORY.txt (everyone)
      • additional credits where not already listed (e.g. patched security issues) (everyone)
    • top and tail HISTORY.txt with additional information (release pilot or co-pilot)
    • tag public/admin themes with release tag (@philwareham)
    • tag Textpacks and Pophelps with release tag (@philwareham)

Take Off

  • take off
    • package up for GitHub and .com (release pilot)
    • update latest.zip and latest.tar.gz in server config (@petecooper)
    • update language pack links in server config (@petecooper)
    • update demo site (@petecooper)
    • publish .com blog post (release pilot, or assigned person)
    • forum announcement (release pilot, or assigned person)
    • forum feedback (release pilot, or assigned person)

Inflight service

@petecooper
Copy link
Member Author

Looking at the plans for the PHP 8.1.0 schedule, GA is planned to arrive November 25 2021. The issue queue for 4.8.8 is currently empty, so we have a few months to housekeep existing issues for some easy / effective wins.

With that in mind, it seems pretty straightforward to tag 4.8.8 as a PHP 8.1 maintenance release, with a few bits of tidying as we go. Should a priority release be needed in the coming months before PHP 8.1 drops, we can defer any other PHP 8.1 changes to a 4.8.9 release.

@Bloke @bloatware @philwareham Does that sound reasonable for now? Anything I've missed?

@Bloke
Copy link
Member

Bloke commented Jul 29, 2021

Works for me. Any small wins from 4.9.0 we can bring forward?

@petecooper
Copy link
Member Author

@Bloke If you have any insight into #1707 that might be an easy win.

There are currently 20 issues without a milestone, so perhaps a couple of passes through those to housekeep might yield some gems. I'll take a nosey after some late lunch.

@petecooper petecooper added this to the v4.8.8 milestone Jul 29, 2021
@Bloke
Copy link
Member

Bloke commented Jul 29, 2021

There is a potential callback bug that needs investigating as part of this release. It's unconfirmed as yet, so no issue to track it at the moment.

@petecooper
Copy link
Member Author

Any small wins from 4.9.0 we can bring forward?

Not strictly from 4.9.0 milestone, but is there anything we can do with #1379 realistically?

@petecooper
Copy link
Member Author

Note sure of the scope here – it may need an issue – but there's an RSS issue that has cropped up. It may be an easy win for 4.8.8: https://forum.textpattern.com/viewtopic.php?pid=331277#p331277

@bloatware
Copy link
Member

This is not really a core issue, but we can try to do something to accommodate hacky plugins.

@petecooper
Copy link
Member Author

Raising this as an RFC since we're about two months from GA: do we need a beta release for 4.8.8?

This is new territory for a patch release, but there's merit in doing the beta dance. There's some discussion about a beta in #1696 but I propose we have a thumbs up or thumbs down to gauge the consensus.

Knowing what we do at the current time, and given this may be the last release on the 4.8 circuit, should we do one or more beta releases for 4.8.8? Thumbs up for 'Yes', thumbs down for 'No'. Paging @bloatware @Bloke @philwareham for input, and any readers with an opinion either way.

Thank you.

@Bloke
Copy link
Member

Bloke commented Sep 25, 2021

A beta seems prudent given the changeset.

@phiw13
Copy link

phiw13 commented Sep 27, 2021

A beta seems prudent […]

+9

@petecooper
Copy link
Member Author

Unless there's any objection, a beta seems like the way forward. Paging @bloatware & @philwareham – please sound off if you're against the idea for any reason.

If no objection, I'll put a post in the forum, on the socials and a short .com blog post with our beta intentions.

@bloatware
Copy link
Member

I'm fine with a beta, just thinking in two months it could get irrelevant. We are rarely keeping quiet when new ideas/requests come.

@petecooper
Copy link
Member Author

We are rarely keeping quiet when new ideas/requests come.

Oh, definitely. +1.

It's been a while since we had a beta release, and if it becomes a formality then that reinforces we were perhaps right to do it…but if there are issues uncovered, we may be able to address them easily for the GA release. Either way, there is some value to the end users (and us, because we get more practice with releases).

@phiw13
Copy link

phiw13 commented Sep 28, 2021

I'm fine with a beta, just thinking in two months it could get irrelevant.

I would expect a putative beta to be released ~ 2 weeks before final release, not much earlier and certainly not now.

@petecooper
Copy link
Member Author

@phiw13 – Agreed, I updated OP with provisional guideline dates before your post above. Would appreciate your take on this, if appropriate.

@petecooper
Copy link
Member Author

@bloatware - I think the penny just dropped when I re-read my comments and your reply, then @phiw13's comments.

I should clarify: I was proposing a beta release around the time of PHP 8.1.0 GA, not now or imminently, then Textpattern 4.8.8 when we're happy it's playing nicely (let's say a few weeks later, assuming no major snags).

@bloatware
Copy link
Member

@petecooper that would be great, thank you. I have tried, but failed to make it work.

@petecooper
Copy link
Member Author

If #1774 is confirmed, we should fix it first, imo.

It appears to be a docs / procedural issue not code.

@petecooper
Copy link
Member Author

I can run the 4.8.8 release unless there are any objections.
@Bloke - please shout if you want dibs and/or a co-pilot.

Last and final boarding call, any reasons to NOT release today?

@Bloke
Copy link
Member

Bloke commented Jan 22, 2022

Are we happy with the resolution of #1774 then? Is it worth fixing #1775 first?

@petecooper
Copy link
Member Author

petecooper commented Jan 22, 2022

#1774 appears to be OK, I followed the instructions from @jools-r and it worked just fine. Docs need some tidying but that's not a showstopper.

The scope of #1775 is not fully clear to me, and that's a me problem, but the idea of relocating plugins from location A to location B on a patch release makes me a bit nervous. I could definitely see #1440 being a good contender for 4.9, which would take care of a bunch of stuff in the process. Plugin authors will need some notice on upcoming changes, too.

That said, multisite is a neat feature that could be overhauled & marketed for the next release branch, especially if we can weaponise some evangelists who run multiple sites on the same server to actually use it in anger.

@Bloke
Copy link
Member

Bloke commented Jan 22, 2022

Yeah, I'm not sure either. #1775 is kind of an oversight when we introduced the /textpattern/plugins directory. Arguably a bug because we're implying that your shared textpattern base install has to have the same plugins in all sites, since they're served from a central location. It's far better to have the plugin path cognisant of the constant so people can move the plugins out of the central area and into one of the per-site directories by simply (re)defining it in config.php. Adds flexibility. I can't see any backwards compatibility issue with @jools-r 's proposed patch

@petecooper
Copy link
Member Author

I can't see any backwards compatibility issue with @jools-r 's proposed patch

Ah, OK - if it's that straightforward then perhaps it's an easy win.

@petecooper
Copy link
Member Author

FYI, anticipating a PR from @jools-r to address #1775 so release will realistically be tomorrow or after.

@petecooper
Copy link
Member Author

Issue queue is clear, time for us to get this sucker out, I think.

Dibs unless @Bloke wants to run it. ETA: today (Monday, January 24th 2022) unless anyone says so.

Paging @philwareham & @bloatware - happy to proceed?

@philwareham
Copy link
Member

Yes, I'm happy to go. Will check Crowdin to see if any new translations need to be added to the Textpacks and Pophelp - then we can tag those repos for release. I'll also tag the themes and admin themes when you are ready to proceed.

@Bloke
Copy link
Member

Bloke commented Jan 24, 2022

Yay. Let's do this thing. Happy for you to run it, thank you. We probably just want to mention in the release notes the potential backwards-compatibility issue with multi-site plugins dir.

@petecooper
Copy link
Member Author

backwards-compatibility issue with multi-site plugins dir

@Bloke - is that something you can do, please? Assume I'm a thick-o.

@petecooper
Copy link
Member Author

Will start the release at 1300UTC, tools down 1245UTC latest, please and thanks.

Gitter is open for any backchannel comms.

@Bloke
Copy link
Member

Bloke commented Jan 24, 2022

History updated

@petecooper
Copy link
Member Author

Tools down, sirs. Showtime!

@philwareham
Copy link
Member

I just need to make sure admin themes are tagged properly. 5 mins.

@philwareham
Copy link
Member

OK, go for it!

@petecooper
Copy link
Member Author

@petecooper
Copy link
Member Author

I think we're looking at a 4.8.9 before 4.9.0 hits the shelves. PHP minor releases are yearly, and if we're aiming for support then we should expect beta + release candidates from early summer onwards, release end of November 2022 - 10 months-ish away.

So, do we spin 4.8.8 branch into 4.8.9 now? Need to know before I wrap up the release process, since the toolkit assumes dev is the way forward. For what it's worth, main is up to date…so perhaps better to spin that out to 4.8.9 instead?

Paging @bloatware, @Bloke & @philwareham for guidance.

@philwareham
Copy link
Member

I'd rather move on from 4.8.x branch now - more work keeping two branches in sync.

@petecooper
Copy link
Member Author

Fair point. It would be straightforward enough to spin a branch off main when PHP 8.2 stuff needs changes, I guess. We're not gonna have 4.9 ready this year, if we're using past release series as a timeline guide, that's my concern.

@Bloke
Copy link
Member

Bloke commented Jan 24, 2022

Yeah, if we need 4.8.9, we can spin it off main. Once everything's merged to main, and we're happy everything's sorted, the v4.8.8 branch can be axed.

@petecooper
Copy link
Member Author

petecooper commented Jan 24, 2022

Awaiting confirmation from Paul at Pentest re: co-ordinated release of blog posts. ETA: 1600UTC. Assuming that goes to plan, I'll wrap up loose ends and we're done.

@petecooper
Copy link
Member Author

Our sites are updated, release post goes live 1600UTC (two mins), I'll wrap up the rest of the stuff and we're done.

@petecooper
Copy link
Member Author

@philwareham
Copy link
Member

Cheers Pete - great stuff. I cleared the cache at Cloudflare just to ensure the blog article appears for everyone (we have quite an aggressive cache there).

@petecooper petecooper unpinned this issue Jan 24, 2022
@petecooper
Copy link
Member Author

Done.

@Bloke
Copy link
Member

Bloke commented Jan 25, 2022

Super work everyone, and thanks Pete for taking the reins on the release. Another fabulous addition to the Textpattern release line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants