Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to undefined function privs() #217

Closed
ghost opened this issue Oct 4, 2014 · 4 comments
Closed

Call to undefined function privs() #217

ghost opened this issue Oct 4, 2014 · 4 comments

Comments

@ghost
Copy link

@ghost ghost commented Oct 4, 2014

From Alexande...@gmail.com on June 23, 2012 22:59:51


Fatal error: Call to undefined function privs() in /var/www/localhost/htdocs/textpattern/lib/txplib_head.php on line 133
Original issue: http://code.google.com/p/textpattern/issues/detail?id=213

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From stefdawson on June 24, 2012 04:57:21

More info please. Which version of Textpattern, under what circumstances do you see the error, etc? It could be a plugin.

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From Alexande...@gmail.com on June 24, 2012 08:41:05

current version, r3832 .
installation only with plugin bot_privs.
unckeck permission to admin sub-tabs.
press admin tab in menu - see blank page, in code see this strings.

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From stefdawson on June 26, 2012 02:16:16

OK, I know why it's doing it. If you shut off the admin tab entirely, txplib_head is still trying to populate the multi-edit dropdown with a call to the privs() function that is contained in include\txp_admin.php.

Under the core, it's never be possible to switch off the admin tab (primarily because of the password change functionality) but plugins like bot_privs and smd_user_manager permit it and should be protected from this kind of (lack of) encapsulation error.

Simplest solution would be to move the privs() function out of txp_admin.php to one of the library files. Alternatively, Gocom is working on refactorisation of the multi-edit toolset which might bring with it a better workflow and less reliance on functions that are defined elsewhere.

So we'll sit on this for a few days and see what happens with the multi-edit code changes; then resolve it either way next week.

Status: Confirmed
Owner: stefdawson
Labels: Priority-Medium

@ghost
Copy link
Author

@ghost ghost commented Oct 4, 2014

From stefdawson on June 28, 2012 15:10:08

Fixed in r3859 .

Status: Fixed

@ghost ghost closed this Oct 4, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants