Conversation
Owner
|
This definitely looks like a useful function. Could you perhaps swap the parameters of the sort function (so first the index and then the comparator)? I think that it might be slightly more readably when calling the function with a lambda function as comparator. I don't really like that both variables are initialized on one line, so maybe you could also either use a ternary operator (and make s1 and s2 const) or rewrite the function as follows? sf::String s1;
if (index < a.texts.size())
s1 = a.texts[index].getString();
sf::String s2;
if (index < b.texts.size())
s2 = b.texts[index].getString(); |
Contributor
Author
|
good points, I'll fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I not think that it's the best solution but as for me it's still better than removing all items and adding them back on each sorting.
If these changes is appropriate I'll also add tests.