Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiselect to ListView #113

Merged
merged 1 commit into from Oct 12, 2019
Merged

Add multiselect to ListView #113

merged 1 commit into from Oct 12, 2019

Conversation

Kvaz1r
Copy link
Contributor

@Kvaz1r Kvaz1r commented Oct 11, 2019

I decided to add setSelectedItems function too because I don't know how to provide tests without it.
I am not a native English speaker so there are could be grammar errors in descriptions.

@texus
Copy link
Owner

@texus texus commented Oct 11, 2019

Thanks. The code looks fine on first sight. I'll merge it soon, after I had the time to look at the code in more detail.

@texus
Copy link
Owner

@texus texus commented Oct 12, 2019

On closer inspection I found that the code wasn't polished enough to be merged as-is. It contained several issues such as text colors not being updated properly and not being able to unselect items except by clicking on another item (which wasn't possible once all items were selected).
I ended up rewriting several parts of the code. You might want to check out the new code and test that everything still works and verify that I didn't accidentally remove something that you added. Function names are a bit different as well, I ended up using "Indices" instead of "Indexes" (both are correct English, but .NET also uses "Indices" for their ListView as well).

@texus texus merged commit 5befe8f into texus:0.8 Oct 12, 2019
2 checks passed
texus added a commit that referenced this issue Oct 12, 2019
…lect support in ListView that was provided in PR #113
@Kvaz1r Kvaz1r deleted the ListViewMultiSelect branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants