Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
  • 4 commits
  • 2 files changed
  • 0 commit comments
  • 3 contributors
Commits on Feb 19, 2013
@tfarina Removed unused UnitsWaiting() function from State class.
This function was added at 307f0bb("and some basic implementation"), but nobody
calls it anymore.

Signed-off-by: Thiago Farina <tfarina@chromium.org>
855f4eb
Commits on Feb 24, 2013
Bei Zhang Browse command does not parse URL correctly b7f11b3
@martine martine Merge pull request #502 from tfarina/rm-unused-fun
Removed unused UnitsWaiting() function from State class.
45e7d32
@martine martine Merge pull request #507 from ikarienator/master
Browse command does not parse URL correctly
a010af6
Showing with 3 additions and 4 deletions.
  1. +2 −1 src/browse.py
  2. +1 −3 src/state.h
View
3 src/browse.py
@@ -29,6 +29,7 @@
import subprocess
import sys
import webbrowser
+import urllib2
from collections import namedtuple
Node = namedtuple('Node', ['inputs', 'rule', 'target', 'outputs'])
@@ -151,7 +152,7 @@ def ninja_dump(target):
class RequestHandler(httpserver.BaseHTTPRequestHandler):
def do_GET(self):
assert self.path[0] == '/'
- target = self.path[1:]
+ target = urllib2.unquote(self.path[1:])
if target == '':
self.send_response(302)
View
4 src/state.h
@@ -66,9 +66,7 @@ struct Pool {
/// Dump the Pool and its edges (useful for debugging).
void Dump() const;
-private:
- int UnitsWaiting() { return delayed_.size(); }
-
+ private:
string name_;
/// |current_use_| is the total of the weights of the edges which are

No commit comments for this range

Something went wrong with that request. Please try again.