Tom Fennelly tfennelly

Organizations

@cloudbees @jboss-switchyard @infinispan @smooks
@tfennelly

Ignore above comment re nulljob. It's because I'm running the plugin via HPI.

tfennelly commented on pull request jenkinsci/maven-plugin#48
@tfennelly

:bee:

tfennelly commented on pull request jenkinsci/maven-plugin#48
@tfennelly

It looks like the above changes are just fixing an issue identified by Findbugs, right?

@tfennelly

@jacob-keller @scoheb While testing I see the nulljob in the event being sent back to the gerrit server (from the gerrit plugin): Does that look l…

tfennelly commented on pull request jenkinsci/workflow-plugin#147
@tfennelly

:bee: I just reviewed the commits since the last time I looked at this and I did it kinda quickly. GitSampleRepoRule is great .... I like how it clean…

tfennelly commented on pull request jenkinsci/workflow-plugin#147
@tfennelly

NIT: How cryptic will the above IllegalStateException("inappropriate context") exceptions be if they appear to the user? Or will the user ever see …

tfennelly commented on pull request jenkinsci/workflow-plugin#147
@tfennelly

General point ... The following code pattern appears a number of times: sampleRepo.write("jenkins.groovy", "<script-code>"); sampleRepo.write("file…

tfennelly commented on pull request jenkinsci/workflow-plugin#147
@tfennelly

Looks like you are calling sampleRepo.write for 2 files above, but only adding 1 of them to the repo ("jenkins.groovy"). Was that intentional?

@tfennelly

@jacob-keller Right, I didn't see a way of doing it for workflow. So, the easiest thing (for now) might be to mark it as a missing feature for Work…

@tfennelly

:bee:

@tfennelly

Auto removing zombie triggers after a Gerrit server is removed seems to make sense to me. In any case (and imo), the debate on the pros and cons of…

tfennelly commented on pull request stapler/stapler#53
@tfennelly

@kohsuke maybe have a look at this. I added a test.

@tfennelly
@tfennelly
tfennelly commented on pull request jenkinsci/jenkins#1774
@tfennelly

I'm not going to do anything more on this for a while. What a PITA. @KostyaSha thanks for spending time looking though it. I'll make those fixes if…

@tfennelly
@tfennelly
@tfennelly
@tfennelly
@tfennelly
@tfennelly
@tfennelly
@tfennelly
  • @tfennelly f132d34
    Dependency exclusions for http commons + some test fixes
@tfennelly
@tfennelly
@tfennelly
  • @tfennelly f7fa157
    UseRecipesWithJenkinsRuleTest compiling against HtmlUnit 2.17
  • @tfennelly eb285c8
    TooManyJobsButNoViewTest compiling against HtmlUnit 2.17
  • 1 more commit »
@tfennelly
  • @tfennelly 998f91f
    RekeySecretAdminMonitorTest compiling against HtmlUnit 2.17
@tfennelly
  • @tfennelly 86a7d5d
    DirectlyModifiableViewTest compiling against HtmlUnit 2.17
tfennelly opened pull request jenkinsci/jenkins#1774
@tfennelly
[WiP] Attempting to upgrade HtmlUnit to v2.17 (from forked version)
16 commits with 234 additions and 126 deletions
@tfennelly