Skip to content

Tom Fennelly
tfennelly

Organizations

@cloudbees @jboss-switchyard @infinispan @smooks
tfennelly commented on pull request jenkinsci/jenkins#2006
@tfennelly

@daniel-beck the advanced options bug is fixed now. On to the next bug :)

tfennelly commented on pull request jenkinsci/workflow-plugin#339
@tfennelly

@amuniz however, as we were saying yesterday, it would be nice to create an NPM package that contains a module to do this kind of thing without res…

tfennelly commented on pull request jenkinsci/workflow-plugin#339
@tfennelly

:bee: LGTM

@tfennelly
  • @tfennelly af48c76
    Fixed bug in finder - not revealing sections before looking for matches
@tfennelly
  • @tfennelly 123af00
    Rename ConfigRowSet to ConfigRowGrouping
@tfennelly
tfennelly commented on pull request jenkinsci/workflow-plugin#334
@tfennelly

@jglick hmmm ... those failures might be my fault ?? ... sorry. Will have a look in a bit.

tfennelly commented on pull request jglick/workflow-plugin#2
@tfennelly

Diff with ignore WS turned on.

tfennelly commented on pull request jenkinsci/workflow-plugin#334
@tfennelly

@jglick I created a PR on your branch with what I hope will fix your ACE editor issues. Maybe give it a try and let me know. Hopefully it works.

tfennelly opened pull request jglick/workflow-plugin#2
@tfennelly
Support multiple workflow script editors on a single page
1 commit with 125 additions and 106 deletions
@tfennelly
@tfennelly

will leave others to bee or not-to-bee

@tfennelly

Tests look great (no clue what they're doing). NIT: Looks like they could be dried out a bit though - fair amount of duplication around calls to th…

@tfennelly

That looks a bit strange?

@tfennelly

:bee:

@tfennelly
  • @tfennelly a1a516c
    Remove setTimeout on callback exec
@tfennelly
  • @tfennelly 02240d4
    Merge pull request #336 from tfennelly/feature-NotExecutedNodeAction-…
  • @tfennelly ffbcacb
    Remove `NotExecutedNodeAction` XStream alias from `SimpleXStreamFlowN…
  • 1 more commit »
@tfennelly
PR 333 fixups for `NotExecutedNodeAction`
2 commits with 2 additions and 4 deletions
tfennelly commented on pull request jenkinsci/workflow-plugin#336
@tfennelly

@jenkinsci/code-reviewers @reviewbybees

@tfennelly
PR 333 fixups for `NotExecutedNodeAction`
2 commits with 2 additions and 4 deletions
@tfennelly
tfennelly commented on pull request jenkinsci/workflow-plugin#333
@tfennelly

@jglick @svanoort ok, I'll create a new fixup PR to move NotExecutedNodeAction and to move the backward compat XStream aliasing out of here.

tfennelly commented on pull request jenkinsci/workflow-plugin#333
@tfennelly

You recommended numerous different places, so I guess @svanoort just got lost.

@tfennelly
@tfennelly
[JENKINS-32561] Adding NotExecutedNodeAction
5 commits with 32 additions and 2 deletions
@tfennelly
tfennelly commented on pull request jenkinsci/workflow-plugin#333
@tfennelly

They are not "needed", but they are not an issue either. Just a matter of taste.

tfennelly commented on pull request jenkinsci/workflow-plugin#333
@tfennelly

exec_state came about because I was unable to figure out how to nest ${} expressions inside each other. In any case, this is perfectly fine too.

Something went wrong with that request. Please try again.