Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification with type='web' produce an exception #585

Closed
jlguardi opened this issue Jan 26, 2015 · 1 comment
Closed

notification with type='web' produce an exception #585

jlguardi opened this issue Jan 26, 2015 · 1 comment
Labels

Comments

@jlguardi
Copy link
Collaborator

@jlguardi jlguardi commented Jan 26, 2015

I've recieved an exception from protocol_notification/layer.py +39

def recvNotification(self, node):
        if node["type"] == "picture":
            ....
        else:
            self.raiseErrorForNode(node)

due to notification of type 'web'. Obviously it is no managed on this function and I've fixed this issue adding:

      if node["type"] == "web
            pass

However, I'd like to manage it properly so I need to know what does it mean. Does somebody know?

@erhan-
Copy link

@erhan- erhan- commented Jan 26, 2015

These are part of the new Web functionality at: https://web.whatsapp.com/
I had this same "issue" yesterday when i tried it out for the first time.

@tgalal tgalal added the feature label Feb 1, 2015
@tgalal tgalal added this to the Protocol Complete milestone Feb 1, 2015
@jlguardi jlguardi changed the title notification with type='web' priduce an exception notification with type='web' produce an exception Feb 2, 2015
@tgalal tgalal closed this in 69e4e57 May 11, 2015
tgalal added a commit that referenced this issue May 11, 2015
Fix #585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.