added bigint type to postgresql #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merged & pushed into the 0.5.0 release. |
|
No Problem. Glad to Help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigint is treated as an integer, since typeBigInteger isn't defined on
clients/server/postgres/schemagrammar.jsI was going to write the tests, then I saw that the schemagrammar files are untested... and I don't really think I should write all the tests for the file, especially since I am not familiar with the code base. It would be nice to see it done with mysql or sqlite first.
So your call. I'll make the PR without tests, and you can reject it if you want. I can always help write the tests once I get an example to go off of.
This should help with postgres problems I mentioned in TryGhost/Ghost#1554 and TryGhost/Ghost#1555