Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Undefined bindings check interfering with custom serializing done in Pg's prepareValue #1898
I'm still using Knex with Pg and Pg's custom type parsers and its serializers (through
I suggest switching to test checking whether the object at hand is a plain one (with its
Knex version in discussion is v0.12.6 and RAW queries are
During implementation I naturally didn't give this much thought. I think checking for plain objects is fine, as long as named bindings remain plain objects only as well (
Perhaps it would also be a good idea to make a config switch for this to completely turn it off as well, but on by default.
Sure. I'm all for disabling. I overwrote the
Not sure what you meant by "as long as named bindings remain plain objects", but to reiterate, bindings themselves need not remain plain objects as, for example, with the Postgres module there's a later serialization step converting objects to final types anyways.