New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool settings confusing in 0.14 (IdleTimeout) #2322

Closed
wubzz opened this Issue Nov 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@wubzz
Collaborator

wubzz commented Nov 13, 2017

Version 3 upgrade docs for generic-pool are extremely vague and unclear on many changes. One of these changes is a new setting called evictionRunIntervalMillis which essentially equals the old reapInterval setting. Unfortunately knex test suite did not cover this in #2208.

In short the setting is used to start a timer which checks two other settings: idleTimeoutMillis and softIdleTimeoutMillis.

In generic-pool v2 this timer has a default value of 1000ms. In v3 however, it defaults to 0, which is the same as "never run any checks". This results in quite the breaking change since existing applications would expect idleTimeoutMillis to still work out of the box, but such is not the case anymore.

While this is not directly a knex issue, I still want to suggest that we update the docs to reflect this change, as it most likely affects a whole lot of applications that are currently using knex.

Reference: coopernurse/node-pool#178

Will move to doc repo if agreed.

@wubzz

This comment has been minimized.

Show comment
Hide comment
@wubzz

wubzz Nov 13, 2017

Collaborator

CC @elhigu

Collaborator

wubzz commented Nov 13, 2017

CC @elhigu

@elhigu

This comment has been minimized.

Show comment
Hide comment
@elhigu

elhigu Nov 14, 2017

Collaborator

Awesome!

Collaborator

elhigu commented Nov 14, 2017

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment