New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for mariasql and other dead dialects #2461

Closed
elhigu opened this Issue Feb 11, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@elhigu
Collaborator

elhigu commented Feb 11, 2018

That driver is pretty much dead (https://github.com/mscdex/node-mariasql) and during stress testing it with flaky connections it crashes without being able to fix it in knex side

Mikaels-MacBook-Pro-2:stress-test mikaelle$ node reconnect-test-mysql-based-drivers.js | grep -A 3 -- "- STATS "
------------------------ STATS PER SECOND ------------------------
{ mysql: { queries: 0, results: 0, errors: 0 },
  mysql2: { queries: 0, results: 0, errors: 0 },
  maria: { queries: 302, results: 289, errors: 12.5 } }
Assertion failed: (!persistent().IsEmpty()), function Unref, file ../../nan/nan_object_wrap.h, line 106.
Mikaels-MacBook-Pro-2:stress-test mikaelle$ 

People should use mysql / mysql2 drivers with mariadb and having this option is misleading.

@wubzz

This comment has been minimized.

Collaborator

wubzz commented Feb 17, 2018

Honestly no clue how the oracle parts of knex works, but am I correct in assuming strong-oracle falls under this category?

websql ?

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Feb 19, 2018

Yes both. I see if I can move some alternative dialects to separate packages.

This was referenced Feb 19, 2018

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Feb 19, 2018

Yeah let's take out strong-oracle and mariasql, and make a note that if you want to use MariaDB you can use the mysql driver. I could go either way on websql, not sure if people are using it with cordova or anything.

Eventually I'd like to get a better standard for how to author & contribute dialects. Getting back into the codebase after awhile and realizing how much the overall lib structure could use a good cleanup - probably will punt on that as part of some bigger changes after 1.0 though.

@wubzz

This comment has been minimized.

Collaborator

wubzz commented Jul 13, 2018

Closing as both dialects have been removed from codebase.

@wubzz wubzz closed this Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment