Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types/result.d.ts in v0.17.4 package, typecscript can't compile app code. #3271

Closed
jeremychone opened this issue Jun 8, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@jeremychone
Copy link

commented Jun 8, 2019

Environment

Knex version: 0.17.4
Database + version: postgresql 11
OS: mac

Bug

  1. Explain what kind of behaviour you are getting and how you think it should do

After upgrading to v0.17.4 (from v0.17.3), we get a typescript error

image

in v0.17.4 the new types/result.d.ts seems to be missing from the npm package.

image

Workaround

npm install knex@0.17.3

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

ouch. lemme fix it real quick

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

@jeremychone Could you please try 0.17.5?

@jeremychone

This comment has been minimized.

Copy link
Author

commented Jun 8, 2019

@kibertoad Just did, works. Thank you!

@jeremychone jeremychone closed this Jun 8, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

np, thanks for reporting it quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.