Use util.promisify instead of Bluebird.promisify #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what to do with Bluebird.promisifyAll in https://github.com/tgriesser/knex/blob/master/lib/dialects/oracle/index.js#L85 |
|
node-oracle hasn't been updated since 2016 and is deprecated in favor of node-oracledb. Support for it can perhaps just be dropped. |
kibertoad
reviewed
Oct 12, 2019
lib/migrate/MigrationGenerator.js
Outdated
| return bluebird | ||
| .promisify(fs.stat, { context: fs })(dir) | ||
| .catch(() => bluebird.promisify(mkdirp)(dir)); | ||
| return promisify(fs.stat)(dir).catch(() => promisify(mkdirp)(dir)); |
There was a problem hiding this comment.
{ context: fs } part is irrelevant?
There was a problem hiding this comment.
yes, but i cant find it in official docs or changelogs
only this example
https://nodejs.org/docs/latest-v8.x/api/util.html#util_util_promisify_original
|
Bunch of conflicts came up. |
maximelkin
force-pushed
the
bluebird_remove_promisify
branch
from
589025e
to
59bf421
Compare
kibertoad
approved these changes
Oct 15, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3257