Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift up dialect specific methods in the CreateTableBuilder #3532

Merged
merged 3 commits into from Nov 21, 2019
Merged

Conversation

@kibertoad
Copy link
Collaborator

@lorefnon

 2) Integration Tests

       oracle | oracledb

         Joins

           accepts a callback as the second argument for advanced joins:

     select * from "accounts" left join "test_table_two" on "accounts"."id" = "test_table_two"."account_id" or "accounts"."email" = "test_table_two"."details" order by "accounts"."id" asc - ORA-00932: inconsistent datatypes: expected - got CLOB

  Error: ORA-00932: inconsistent datatypes: expected - got CLOB

      at Client_Oracledb._query (lib/dialects/oracledb/index.js:246:19)

      at Client_Oracledb.query (lib/client.js:165:17)

      at Runner.query (lib/runner.js:135:36)

      at /home/travis/build/knex/knex/lib/runner.js:39:23

  From previous event:

      at Runner.run (lib/runner.js:25:16)

      at Builder.Target.then (lib/interface.js:14:43)

I think this is a new failure. Can you check it out?

@lorefnon
Copy link
Collaborator Author

@kibertoad yeah, this broke due to an accidental change. Fixed now.

@kibertoad kibertoad merged commit 79ccb7d into master Nov 21, 2019
@kibertoad kibertoad deleted the #3478 branch November 21, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants