fix/4068 batchInsert correct definitions #4131
Conversation
|
@maximelkin One of the TSD tests are failing, try running |
test-tsd/batchInsert.test-d.ts
Outdated
|
|
||
| // assert any bad column from returning list gives error | ||
| // tsd gives error on this, lol | ||
| /*expectError( |
There was a problem hiding this comment.
Do you think that tsd is wrong here? If there is an easy self-contained repro possible, perhaps an issue at https://github.com/SamVerschueren/tsd/issues could be opened?
There was a problem hiding this comment.
Thank you. Can you add the reference to that bug report next to the commented out code?
There was a problem hiding this comment.
I will try to fix it fast in tsd
There was a problem hiding this comment.
does tsd have any caches? I cant reproduce it anymore on extracted example
There was a problem hiding this comment.
Not tsd per se, but TypeScript definitely has some caches, so that might have been a factor.
There was a problem hiding this comment.
Oh, i copied stacktrace from wrong place
There was a problem hiding this comment.
Error pops up because this expression give 2 errors, but expectError allows only one
There was a problem hiding this comment.
alternative fix is expectError(expectError())
|
tsc typecheck failing pipeline, I will try to fix (probably disable typecheck on them idk) |
maximelkin
force-pushed
the
fix/4068_correct_batchInsert_definitions
branch
from
abea2a8
to
c98699c
Compare
|
Thanks! |
Closes #4068