New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite delete does not report the number affected rows #45

Closed
nrvalliere opened this Issue Aug 23, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@nrvalliere

nrvalliere commented Aug 23, 2013

Sqlite delete does not report the number affected rows. It looks like sqlite3.js is using the all() method instead of run() when executing delete queries. Updating line 26 to the following fixes the problem:

var method = (builder.type === 'insert' || builder.type === 'update' || builder.type == 'delete') ? 'run' : 'all';

(I know I should probably learn to do a pull request but I've not used git before and don't feel like spending the time for a one line edit.)

@tgriesser tgriesser closed this in 5db8c8a Aug 23, 2013

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Aug 23, 2013

Thanks @taidaishar, should be fixed - and just so you know, github actually makes it easy enough that if you fork a repository, you can edit the file in the browser and click to create a pull request.

elliotf pushed a commit to elliotf/knex that referenced this issue Nov 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment