New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leftJoin can't give a value of 0 #953

Closed

rickytan opened this issue Aug 29, 2015 · 0 comments

rickytan commented Aug 29, 2015

I have a statement with

knex('xxx').leftJoin('abc as a', 'a.field', 0);

And it generate a QUERY of : select * from xxx left join abc as a on a.field = , the 0 is missing. Perhaps you write a code as followering:

if (arguments[1]) {

}

which should be:

if (typeof arguments[1] === 'undefined') {

}

😦

The text was updated successfully, but these errors were encountered:

harriha added a commit to harriha/knex that referenced this issue


          Check for undefined explicitly. Fixes knex#953.

a866046

Value 0 didn't work as expected with the previous check.

harriha added a commit to harriha/knex that referenced this issue


          Check for undefined explicitly. Fixes knex#953.

e279d83

Value 0 didn't work as expected with the previous check.

harriha mentioned this issue

Allow zero in join clause, fixes #953 #958

Merged

rhys-vdw closed this as completed in

4026da3

rhys-vdw added a commit that referenced this issue


          Merge pull request #958 from harriha/bugfix/allow-zero-in-join-clause

beaccbf

Allow zero in join clause, fixes #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment