New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leftJoin can't give a value of 0 #953

Closed
rickytan opened this Issue Aug 29, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@rickytan

rickytan commented Aug 29, 2015

I have a statement with

knex('xxx').leftJoin('abc as a', 'a.field', 0);

And it generate a QUERY of : select * from xxx left join abc as a on a.field = , the 0 is missing. Perhaps you write a code as followering:

if (arguments[1]) {

}

which should be:

if (typeof arguments[1] === 'undefined') {

}

😦

harriha added a commit to harriha/knex that referenced this issue Aug 30, 2015

Check for undefined explicitly. Fixes tgriesser#953.
Value 0 didn't work as expected with the previous check.

harriha added a commit to harriha/knex that referenced this issue Aug 30, 2015

Check for undefined explicitly. Fixes tgriesser#953.
Value 0 didn't work as expected with the previous check.

@rhys-vdw rhys-vdw closed this in 4026da3 Sep 8, 2015

rhys-vdw added a commit that referenced this issue Sep 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment