New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support question mark escaping for knex rendered queries #1058

Merged
merged 4 commits into from Nov 28, 2015

Conversation

Projects
None yet
2 participants
@elhigu
Collaborator

elhigu commented Nov 13, 2015

Fixes bug in #519 by adding more complete support for \? escape sequence

@rhys-vdw

This comment has been minimized.

Collaborator

rhys-vdw commented Nov 14, 2015

Specific comment here.

@rhys-vdw

This comment has been minimized.

Collaborator

rhys-vdw commented Nov 14, 2015

I'm thinking of merging #886, which I believe would conflict with this change. Are you happy to retarget the changes afterwards?

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Nov 14, 2015

@rhys-vdw, sure of course :)

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Nov 24, 2015

@rhys-vdw looks like there has been no activity in #886. Maybe this could be already merged?

@rhys-vdw

This comment has been minimized.

Collaborator

rhys-vdw commented Nov 28, 2015

Yep, looks good to be @elhigu. Cheers. 👍

rhys-vdw added a commit that referenced this pull request Nov 28, 2015

Merge pull request #1058 from elhigu/support-question-mark-escaping-f…
…or-knex-rendered-queries

Support question mark escaping for knex rendered queries

@rhys-vdw rhys-vdw merged commit 51ef27b into tgriesser:master Nov 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elhigu elhigu deleted the elhigu:support-question-mark-escaping-for-knex-rendered-queries branch Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment