Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bugfix/knex hangs when pool is filled with trs #1177
@tgriesser @elhigu @rhys-vdw In regards to #1040 and #1171 , this change will throw a Timeout error including information about the query that was run, when acquiring a connection is not possible or simply takes too long.
I am in no way implying that this is the correct way of fixing this, but it does work. The issues mentioned it needs to be configurable, so a new option has been added to the knex options object. (not the 'Pool' object since technically it has no relevance there)
Not so sure the hacky stuff done in the test file is allowed, but couldn't figure out a better way of doing it.. :)