New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'query-response' event (#1203) #1231

Merged
merged 4 commits into from Mar 7, 2016

Conversation

Projects
None yet
2 participants
@wubzz
Collaborator

wubzz commented Feb 26, 2016

No description provided.

@ngoctranfire

This comment has been minimized.

ngoctranfire commented on 840d2d1 Mar 7, 2016

Nice. Seems you got this one already pretty much done. Looks good too. Do you think its wise to also add test for the events 'query' and 'query-error' as well? I was doing that in my branch

This comment has been minimized.

Owner

wubzz replied Mar 7, 2016

@ngoctranfire There should already be tests for query and query-error.

wubzz added a commit that referenced this pull request Mar 7, 2016

@wubzz wubzz merged commit cddb64c into tgriesser:master Mar 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment