New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.renameColumn should not drop defaultValue or nullable state. #1326

Merged
merged 2 commits into from Apr 1, 2016

Conversation

Projects
None yet
2 participants
@wubzz
Collaborator

wubzz commented Apr 1, 2016

Currently this happens for mysql. Fixes #933

@wubzz

This comment has been minimized.

Collaborator

wubzz commented Apr 1, 2016

cc @gabe-alex I'm no mysql expert, would you mind double-checking that I got this right?

@wubzz wubzz added the 0.11 label Apr 1, 2016

@gabe-alex

This comment has been minimized.

gabe-alex commented Apr 1, 2016

@wubzz Right, seems to work now.
Although, I had to manually copy the changes to my lib folder, since I'm on Windows and building doesn't seem to work here...

@wubzz

This comment has been minimized.

Collaborator

wubzz commented Apr 1, 2016

Cool, merging this then. It'll be in the next release.

@wubzz wubzz merged commit bb9663f into tgriesser:master Apr 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment