Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid SQL in Oracle dialect ping function #1486

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
2 participants
@jacobinary
Copy link

jacobinary commented Jun 10, 2016

"SELECT 1" results in the error: ORA-00923: FROM keyword not found where expected

The correct syntax should be "SELECT 1 FROM DUAL".

@wubzz

This comment has been minimized.

Copy link
Collaborator

wubzz commented Jun 10, 2016

Makes sense this wasn't caught in CI since there's no runners for Oracle (or mssql) integration, only unit.

Cheers for this @jacobinary !

@wubzz wubzz merged commit e3ea261 into tgriesser:master Jun 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jacobinary jacobinary deleted the jacobinary:oraclefix branch Jun 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.