Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add having() and on() missing methods #1674

Merged
merged 2 commits into from Sep 19, 2016
Merged

Add having() and on() missing methods #1674

merged 2 commits into from Sep 19, 2016

Conversation

atiertant
Copy link
Contributor

add missing methods:

  • havingNull
  • havingExists
  • havingIn
  • havingBetween
  • onNull
  • onExists
  • onIn
  • onBetween

@CorvusCorrax CorvusCorrax mentioned this pull request Sep 19, 2016
Merged
@elhigu
Copy link
Member

elhigu commented Sep 19, 2016

Looks good to me, I couldn't find anything to comment :)

@elhigu elhigu merged commit 67b62d3 into knex:master Sep 19, 2016
@elhigu
Copy link
Member

elhigu commented Sep 19, 2016

Was there another pull request for the documentation ?

@elhigu
Copy link
Member

elhigu commented Sep 19, 2016

Looks like there is
knex/documentation#2

@atiertant
Copy link
Contributor Author

exactly

Le 19 sept. 2016 18:24, "Mikael Lepistö" notifications@github.com a
écrit :

Looks like there is
knex/documentation#2 knex/documentation#2

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1674 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF0n_GX3yrQfDAudPVC_4kBa5yWCV81Dks5qrrc4gaJpZM4KAcfo
.

tgriesser added a commit that referenced this pull request Sep 19, 2016
@tgriesser
Merge branch 'master' into refactor
6a965a8 
* master:
  Add having() and on() missing methods and corresponding tests/doc (#1674)
  Bump node-uuid, which I guess is considered insecure
  Add some CI badge to README (npm version, dep status) (#1130)
  Move mariadb connect into Promise block
rslabbert pushed a commit to rslabbert/knex that referenced this pull request Nov 9, 2016
@atiertant
Add having() and on() missing methods and corresponding tests/doc (kn…
cb20a0a 
…ex#1674)
@pmalouin pmalouin mentioned this pull request Feb 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
0.13
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atiertant @elhigu @CorvusCorrax