Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add having() and on() missing methods #1674

Merged
merged 2 commits into from Sep 19, 2016

Conversation

3 participants
@atiertant
Copy link
Contributor

atiertant commented Sep 19, 2016

add missing methods:

  • havingNull
  • havingExists
  • havingIn
  • havingBetween
  • onNull
  • onExists
  • onIn
  • onBetween
@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 19, 2016

Looks good to me, I couldn't find anything to comment :)

@elhigu elhigu merged commit 67b62d3 into tgriesser:master Sep 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 19, 2016

Was there another pull request for the documentation ?

@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Sep 19, 2016

Looks like there is
knex/documentation#2

@atiertant

This comment has been minimized.

Copy link
Contributor Author

atiertant commented Sep 19, 2016

exactly

Le 19 sept. 2016 18:24, "Mikael Lepistö" notifications@github.com a
écrit :

Looks like there is
knex/documentation#2 knex/documentation#2


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1674 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF0n_GX3yrQfDAudPVC_4kBa5yWCV81Dks5qrrc4gaJpZM4KAcfo
.

tgriesser added a commit that referenced this pull request Sep 19, 2016

Merge branch 'master' into refactor
* master:
  Add having() and on() missing methods and corresponding tests/doc (#1674)
  Bump node-uuid, which I guess is considered insecure
  Add some CI badge to README (npm version, dep status) (#1130)
  Move mariadb connect into Promise block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.