New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uuid not node-uuid #1792

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
5 participants
@buildmaster
Contributor

buildmaster commented Nov 21, 2016

node-uuid has been depreciated, so switch dependencies to uuid.

@elhigu elhigu merged commit 825396a into tgriesser:master Nov 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu

This comment has been minimized.

Collaborator

elhigu commented Nov 22, 2016

Thanks!

@ColorfulCow

This comment has been minimized.

ColorfulCow commented Dec 7, 2016

does node-uuid caused some bug? i met a problem , i used knex db.raw() for quering, but got unexpection data only a very small probability will occur, knex version is 0.12.5

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Dec 7, 2016

@ColorfulCow no, it was just deprecated and name of the package in npm was changed to uuid (https://github.com/broofa/node-uuid)

@mikermcneil

This comment has been minimized.

Collaborator

mikermcneil commented Jan 30, 2017

@elhigu If there's any chance we could get this in a release in the next week or so, that'd be awesome. We're using it in Sails v1 :)

Happy to help if there's any blockers

@tjwebb

This comment has been minimized.

Collaborator

tjwebb commented Jan 31, 2017

@buildmaster how sure are we that the 1.x --> 3.x doesn't represent a major version change?

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jan 31, 2017

@tjwebb as far as i know the only function used from the uuid library is the v4 uuid retrieval. Specification of v4 format uuids has not changed so this update won't cause any changes to functionality on knex if you are asking that?

@mikermcneil

This comment has been minimized.

Collaborator

mikermcneil commented Jan 31, 2017

Looks like:

3.0.0 (2016-11-17)

  • remove .parse and .unparse

2.0.0

  • Removed uuid.BufferClass

https://github.com/kelektiv/node-uuid/blob/d8e41bddf6cfd676f81f98fe527a3545087d6514/HISTORY.md#300-2016-11-17

@mikermcneil

This comment has been minimized.

Collaborator

mikermcneil commented Jan 31, 2017

@elhigu looks right to me-- just the .v4() function

@tjwebb

This comment has been minimized.

Collaborator

tjwebb commented Feb 2, 2017

this update won't cause any changes to functionality on knex if you are asking that?

Yea, wanted to determine whether there are any other changes, and whether this will be a patch or a minor for knex. Thanks everyone.

@mikermcneil

This comment has been minimized.

Collaborator

mikermcneil commented Feb 13, 2017

Hey guys, sorry to bug you. Just checking back in with a gentle nudge on getting this published on npm. We can work around if necessary, but it'd be nice to keep everybody on the same release if we can. Again, if there's anything I can do to help here, just let me know and I'm happy to. Thanks!

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Feb 13, 2017

I'll try to get some time to make release, just have to go through all changes and make sure that changelog is uptodate and to see if there was breaking changes.

elhigu added a commit to elhigu/knex that referenced this pull request Feb 15, 2017

mikermcneil added a commit to sailshq/rodestead that referenced this pull request Feb 21, 2017

@mikermcneil

This comment has been minimized.

Collaborator

mikermcneil commented Feb 21, 2017

@elhigu Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment