Ensure that 'client' is provided in knex config object #1822

merged 3 commits into from Dec 11, 2016


None yet

2 participants

wubzz commented Dec 8, 2016 edited

The option is documented as required, but it's currently not being validated. This leads to strange side effects such as ones describe in #1628.

I also took the liberty of adding modifiers to the base columpcompiler as it currently does not have this property, but it should.

@wubzz wubzz requested a review from elhigu Dec 8, 2016
@elhigu elhigu merged commit a4bfee7 into tgriesser:master Dec 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment