Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass rollback errors through to transaction promise in mssql dialect … #1885

Merged
merged 1 commit into from Jan 30, 2017

Conversation

Projects
None yet
3 participants
@justinwh
Copy link
Contributor

justinwh commented Jan 27, 2017

…(#1884)

Check for rollback failures on mssql and pass them through to the transaction promise-- attaching the underlying cause as an 'originalError' property. This fixes a hang when mssql server aborts a transaction and the client issues a rollback.

Pass rollback errors through to transaction promise in mssql dialect (#…
…1884)

Check for rollback failures on mssql and pass them through to the transaction promise-- attaching the underlying cause as an 'originalError' property.  This fixes a hang when mssql server aborts a transaction and the client issues a rollback.
@elhigu

This comment has been minimized.

Copy link
Collaborator

elhigu commented Jan 30, 2017

@Grimace1975 could you check this one?

@smorey2 smorey2 merged commit 2fa375f into tgriesser:master Jan 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

elhigu added a commit to elhigu/knex that referenced this pull request Feb 15, 2017

Pass rollback errors through to transaction promise in mssql dialect (t…
…griesser#1884) (tgriesser#1885)

Check for rollback failures on mssql and pass them through to the transaction promise-- attaching the underlying cause as an 'originalError' property.  This fixes a hang when mssql server aborts a transaction and the client issues a rollback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.