New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added clearSelect and clearWhere to query builder #1912

Merged
merged 1 commit into from Feb 20, 2017

Conversation

Projects
None yet
2 participants
@alechirsch
Contributor

alechirsch commented Feb 14, 2017

Copy of #1907, this pull request has my account attached to the commits...

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Feb 20, 2017

If you have time to implement this for returning, limit, order by, join, group by, having, on, would be awesome. Still it won't be super useful since one cannot get for example subquery builders from outside to cleanup parts of subquery (like removing order by from some subquery).

Anyways I'm inclining to accept this feature after all. Maybe we could add new section to documentation, which lists all clearing functions, so it would be clear which parts of query builder can be reset...

Code looks look, only documentations seem to be missing.

@alechirsch

This comment has been minimized.

Contributor

alechirsch commented Feb 20, 2017

I have added documentation for the feature please let me know if I missed anything. Adding to the docs is slightly confusing.

knex/documentation#24

@alechirsch

This comment has been minimized.

Contributor

alechirsch commented Feb 20, 2017

@elhigu I do not have the time right now to add the other clear methods, however it should be easy to do so with the private method _clearGrouping function that I added. Testing would be the most time consuming.

@elhigu elhigu merged commit 9404dba into tgriesser:master Feb 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu

This comment has been minimized.

Collaborator

elhigu commented Feb 20, 2017

thanks!

@elhigu elhigu referenced this pull request Jan 11, 2018

Closed

clear orderBy #2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment