New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing version of connected db in configuration file #1993

Merged
merged 2 commits into from Mar 26, 2017

Conversation

Projects
None yet
2 participants
@elhigu
Collaborator

elhigu commented Mar 26, 2017

Rebased and cleaned up #1959 to see if it passes now.

RockyNiu added some commits Mar 10, 2017

# This is a combination of 3 commits.
# The first commit's message is:
Allow passing config.version variable to knex instead of parsing the DB version from string returned form DB server.

This makes it possible to connect custom databases which are compatible with an official database of certain version.

# The 2nd commit message will be skipped:

#	Update checkVersion
#
#	To use `const` instead of `let` to fix lint error

# The 3rd commit message will be skipped:

#	Revert "Update checkVersion"
#
#	This reverts commit 248907d.
Allow passing config.version variable to knex instead of parsing the …
…DB version from string returned form DB server.

This makes it possible to connect custom databases which are compatible with an official database of certain version.

@elhigu elhigu merged commit 137e1fe into tgriesser:master Mar 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elhigu elhigu referenced this pull request Apr 7, 2017

Open

CockroachDB Support #2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment