New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pure JS driver for PostgreSQL #200

Merged
merged 1 commit into from Mar 14, 2014

Conversation

Projects
None yet
3 participants
@xaka
Contributor

xaka commented Mar 12, 2014

As there is no way to tell npm to not compile native driver, we should use https://github.com/brianc/node-postgres-pure instead which is exactly the same library without native driver, but as knex has no idea about it, i cannot use it. Please take a look at project's homepage.

Add support for pure JS driver for PostgreSQL
As there is no way to tell `npm` to not compile native driver, we should use https://github.com/brianc/node-postgres-pure instead which is exactly the same library without native driver. Please take a look at project's homepage.

tgriesser added a commit that referenced this pull request Mar 14, 2014

Merge pull request #200 from xaka/patch-2
Add support for pure JS driver for PostgreSQL

@tgriesser tgriesser merged commit e65db47 into tgriesser:master Mar 14, 2014

1 check passed

default The Travis CI build passed
Details
@tgriesser

This comment has been minimized.

Owner

tgriesser commented Mar 14, 2014

Cool.

@xaka

This comment has been minimized.

Contributor

xaka commented Mar 14, 2014

Yay! When are you planning to make next minor release?

@tgriesser

This comment has been minimized.

Owner

tgriesser commented Mar 14, 2014

This would be a patch release, traveling today but I'll get to it in the next day or so.

@vvo

This comment has been minimized.

Contributor

vvo commented Apr 8, 2014

nice @xaka

@vvo

This comment has been minimized.

Contributor

vvo commented Apr 8, 2014

The fun thing to note is that all knex users were already using this pure JavaScript driver because
https://github.com/brianc/node-postgres uses it by default unless you require('pg').native.

@xaka

This comment has been minimized.

Contributor

xaka commented Apr 8, 2014

Right, but the point of using pg.js is that you don't need to compile binding.

@vvo

This comment has been minimized.

Contributor

vvo commented Apr 8, 2014

agree, I think node-postgres should be the pure JavaScript binding and he should create a node-postgres-native for people willing to compile..

@knownasilya knownasilya referenced this pull request May 12, 2015

Closed

Fix pg.js regression #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment