Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[Improvement] Replaced push.apply() calls with custom concat() function. #207
Replaced push.apply() calls with custom concat() function so the V8 stack will not exhaust when a complex query is being processed. It doesn't change the behavior in Knex (tests are passing), it just uses different approach to concatenate to an existing array and provides ability to simply reimplement 'concat' function if new, better approach has been found.
With this change we can run really complex queries on our server without V8 terminating the app.
NOTE: This PR also contains fixes to counting, hope that it's fine.