Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add unit tests for table comment #2098
I created tests to add table comment. These are for postgresql, mysql and oracle as it seems to me that
referenced this pull request
Jun 8, 2017
Thanks for tests! They look fine, except that none of the dialects should have tests that .comment with undefined / null / falsy param sets empty string comment. Invalid parameters should throw an error (any parameter that is not string).
So please delete those tests setting comments with non-string arguments and I can merge this.