New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding multiple columns in Oracle #2115

Merged
merged 1 commit into from Jun 10, 2017

Conversation

Projects
None yet
2 participants
@rizip1
Contributor

rizip1 commented Jun 9, 2017

Fix for issue #1916

I also fixed incorrect unit tests to reflect current changes.

@rizip1 rizip1 changed the title from Fix adding more columns in Oracle to Fix adding multiple columns in Oracle Jun 9, 2017

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jun 10, 2017

Could you also enable this line https://github.com/tgriesser/knex/pull/1914/files#diff-b91681a6009d38db70d89305944b4318R332 so that feature is tested with integration test too?

Fix adding more columns in Oracle
* Fix incorrent unit tests to reflect
  current changes
@rizip1

This comment has been minimized.

Contributor

rizip1 commented Jun 10, 2017

Done.

@elhigu elhigu merged commit 16a4eb1 into tgriesser:master Jun 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jun 10, 2017

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment