Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allows to filter seeds and migrations by extensions #2168
This PR addresses issue #1922
Couldn't find any tests that deal with ts/coffee/etc. migrations, so I don't know where to start from. I.e. how to to check that ts migrations is executed/not executed based on loadExtensions parameter? But this is small change, I think it's ok as is.
If this PR is acceptable, I will submit PR to docs too.
@elhigu , I changed default extensions to former SUPPORTED_EXTENSIONS. I also added unit tests for
Actually, I think it is better not to introduce this extra
If everything is ok, I'll proceed with docs PR
Beautiful, I haven't seen such clean code here for a while
Please proceed and if you see places where things could be made better and more safe for the user it is not out of the question to break backwards compatibility. We have been breaking it quite a lot lately while trying to make lib to work more sane manner, like throwing errors when user does something that is not defined or potentially dangerous behaviour.
added a commit
this pull request
Jul 24, 2017
referenced this pull request
Jul 24, 2017
Thanks! Everything seems to be in order. CI have been broken a while so I haven't been able to get some PRs in which were failing (and I've been very busy lately so I haven't got time to do much of maintenance)... so I cannot say anything about schedule yet. Next version will be 0.14.0 since there are again some breaking changes.