New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sorting of statements from update queries (#2169) #2171

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@kurrestahlberg
Contributor

kurrestahlberg commented Jul 25, 2017

Consistent updates where a new field value depends on an another field that gets updated in the same query are impossible across different databases unless the original update order is maintained.

The problem is with MySQL not following the SQL spec as described here: https://dev.mysql.com/doc/refman/5.7/en/ansi-diff-update.html. This causes the value used for calculating another value sometimes already be updated and sometimes not, depending on which database is used and what the names of the fields are if the statements are sorted alphabetically.

This PR removes sorting of statements when building an UPDATE query. A possible future issue is that the key order of an object is not defined in the spec while all known JS engines keep non-integer-like keys in insertion order so this should work correctly across all engines. The order might thus be different with an engine in the future. More info on ordering here: https://bugs.chromium.org/p/v8/issues/detail?id=164

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jul 25, 2017

Should insert be implemented the same way? Even though I don't see the same kind of problems with it so maybe not...

@kurrestahlberg

This comment has been minimized.

Contributor

kurrestahlberg commented Jul 25, 2017

I was thinking the same but as I couldn't think of any reason why there would be an issue when inserting I figured a smaller change is better.

@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jul 25, 2017

Yeah, this looks good to me though. Thanks! @wubzz @tgriesser @rhys-vdw anyone, if there are no objections I'll merge this in tomorrow. I marked this as a breaking change even that this was more like undefined behaviour earlier. Maybe documentation could mention that updates are generated in the Object.key() iteration order of used js-engine. Just to make this functionality documented and official.

@wubzz

This comment has been minimized.

Collaborator

wubzz commented Jul 25, 2017

No opposition from me, this makes sense. My guess is the .sort() originates from a copy-paste of _prepInsert. Don't see a real use case for sorting columns for insert either, tho..

@elhigu elhigu merged commit 03f0fb4 into tgriesser:master Jul 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@elhigu

This comment has been minimized.

Collaborator

elhigu commented Jul 26, 2017

I added documentation issue about this. Thanks!

@kurrestahlberg kurrestahlberg deleted the kurrestahlberg:keep-update-order branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment