Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add redshift support without changing cli or package.json #2233
Hi. We (at Skuid) are trying to get mssql support by updating to latest knex while keeping the redshift support added in https://github.com/trevorsmith/knex. I noticed that the original pull request from that repo included (probably unwanted) changes to cli.js and package.json. Those are reverted in this PR - is it possible that it could go in now?
The integration tests are not working for me because I don't have local instances of mariadb, oracle, mssql, etc. to test against, and I haven't added docker/dockerode configuration for them to run against containers. If that is the only roadblock to accepting, I can do it?
I'm not going to support any new dialect additions unless there is also travis CI configuration running tests for that platform.
If CI works and also the integration tests are ran for redshift in Travis and dialect is properly tested and documented it can be merged in.
And lockfile shouldn't have been committed.
referenced this pull request
Oct 31, 2017
FYI, a timestamp with a default value will trigger an error when inserting data into it (im talking about redshift)
is there a dedicated topic where we can report details like this one ?
to recap, you need a plain timestamp, don't set any flags about null values, default values etc, i think this applies to other field types as well.
GJ making knex compatible with redshift